-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cmake configuration #2022
Fix cmake configuration #2022
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 90.03% 90.00% -0.04%
==========================================
Files 909 909
Lines 32928 32998 +70
==========================================
+ Hits 29646 29699 +53
- Misses 3282 3299 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing COMMAND_ERROR_IS_FATAL
looks good to me (my mistake for adding it in the first place without checking the version requirements).
For CMAKE_EXPORT_COMPILE_COMMANDS
, I'm not convinced it's something that needs to be included in CMakeLists.txt
, though I'm not strongly against it either.
E.g. you can set it as an environment variable instead if you need it, or just set it manually on your build directory (see here).
@benjaminwinger I know that the |
Okay, sounds good. Also, since this is your first time contributing to this repository, you need to agree to the contributor license agreement (see here) (I guess it doesn't actually say that you have to do so explicitly, but stating it explicitly in your PR lets us know that you've read and understand that part). |
@yixinglu Could you please take a look at our CLA at https://github.com/kuzudb/kuzu/blob/master/CLA.md and add a sentence "I have read and agree to the terms under CLA.md." to your PR description if it looks good to you? Once you agree with the CLA we can get this PR merged. Thank you. |
done |
COMMAND_ERROR_IS_FATAL
was introduced in cmake 3.19, see here for details. This is inconsistent with the cmake minimum required version3.11
.I have read and agree to the terms under CLA.md.